Event data corruption in multithreaded firmware #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f event data when threading is enabled
|
So glad to see this fix! I knew I had designed for it to work in principle, but clearly a typo meant that the design wasn't reflected in reality. |
|
Yep, it was unlikely for this problem to have any other origin, since the protocol code is synchronous internally. Would you mind merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes possible corruption of an event data in multithreaded firmware. Symptoms of the problem are described here: http://community.particle.io/t/webhooks-corrupt-data-in-multipart-webhook-response/28683
Doneness:
Bug fixes
[PR #1246]Fixes possible corruption of event data in multi-threaded firmware